Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Interpolation dollar signs showing around completion status #200

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

dougmartin
Copy link
Member

This was a bug introduced during a PR review when the completion status display code was refactored.

This was a bug introduced during a PR review when the completion status display code was refactored.
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (43024c1) 84.61% compared to head (b7a44b9) 84.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files           2        2           
  Lines          39       39           
  Branches       13       13           
=======================================
  Hits           33       33           
  Misses          6        6           
Flag Coverage Δ
jest 84.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scytacki scytacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. :)

@dougmartin dougmartin merged commit 9b07927 into master Oct 17, 2023
5 checks passed
@dougmartin dougmartin deleted the fix-added-interpolation-dollar-signs branch October 17, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants